Annotate core functions and remove sphinx style argument types #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 95.42% 95.46% +0.03%
==========================================
Files 24 26 +2
Lines 1269 1346 +77
Branches 287 287
==========================================
+ Hits 1211 1285 +74
- Misses 33 37 +4
+ Partials 25 24 -1
|
… are being fixed.
devdanzin
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
LGTM, I've only found minor nits, some even in code that didn't change in this PR. Among them, some missed docstring types, a couple of places where typing could be improved and some places where we could optionally add return types. Nothing that should get in the way of merging.
This is a great start and I'd be glad to tackle any improvements from here on if you'd like me to.
| @@ -107,7 +113,7 @@ def revisions(self, path: str, max_revisions: int) -> List[Revision]: | |||
| if self.repo.is_dirty(): | |||
There was a problem hiding this comment.
Some typing information remains in the above docstring and that on find().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
OperatorMetricandArchiverare now genericsthere are possible more places to add types and some violations reported by MyPy, but this is a good start